Skip to content

Commit

Permalink
fix: fix minor regression with tag positioning, dont portal tooltips …
Browse files Browse the repository at this point in the history
…to prevent overflow issues
  • Loading branch information
robinpyon committed Oct 6, 2022
1 parent a823525 commit 4b6e46b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
4 changes: 0 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ All notable changes to this project will be documented in this file. See

- catch errors when preview images fail to be generated ([#88](https://github.com/robinpyon/sanity-plugin-media/issues/88)) ([5b40ad7](https://github.com/robinpyon/sanity-plugin-media/commit/5b40ad7b32f11021e2da9440ca03c73d651ae533))

# Changelog

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.4.11](https://github.com/robinpyon/sanity-plugin-media/compare/v1.4.8...v1.4.11) (2022-09-12)

### Bug Fixes
Expand Down
2 changes: 0 additions & 2 deletions src/components/DialogTags/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import {hues} from '@sanity/color'
import {Box} from '@sanity/ui'
import {DialogTagsProps} from '@types'
import React, {ReactNode, useCallback} from 'react'
Expand Down Expand Up @@ -30,7 +29,6 @@ const DialogTags = (props: Props) => {
<Dialog header="All Tags" id={id} onClose={handleClose} width={1}>
<Box
style={{
borderTop: `1px solid ${hues.gray?.[900].hex}`,
height: '100%',
minHeight: '420px' // explicit height required as <TagView> is virtualized
}}
Expand Down
4 changes: 1 addition & 3 deletions src/components/Tag/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ type Props = {

const TagContainer = styled(Flex)`
height: ${PANEL_HEIGHT}px;
width: 100%;
`

const ButtonContainer = styled(Flex)`
Expand Down Expand Up @@ -55,7 +54,6 @@ const TagButton = (props: TagButtonProps) => {
}
disabled={'ontouchstart' in window}
placement="top"
portal
>
<Button
disabled={disabled}
Expand Down Expand Up @@ -123,7 +121,7 @@ const Tag = (props: Props) => {
}

return (
<TagContainer align="center" justify="space-between" paddingLeft={3}>
<TagContainer align="center" flex={1} justify="space-between" paddingLeft={3}>
<Box flex={1}>
<Text
size={1}
Expand Down

0 comments on commit 4b6e46b

Please sign in to comment.