Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is marked as a draft because I have one question. I have the following comment in the code at the moment:
The main setup_GB function also sets up Audio-In as input and enables the internal pull up, but the Datel/Pelican/Codebreaker/MonsterBrain initialization did everything else except touch this pin. Was that intentional? Or should this pin be initialized also as input for those other devices? Right now I don't see them using that pin, so it's probably just holding whatever setting was there prior.
If the answer is that there is no harm in all of them also initializing Audio-In, then I can do that and remove some extra lines from setup_GB. If not, I can remove the FIXMEs currently in the commit.