Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bad_by_PSD() #145

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nabilalibou
Copy link
Contributor

@nabilalibou nabilalibou commented Apr 14, 2024

Issue #143

Merge Checklist

  • Respect the matlab_strict flag
  • Documentation
  • Clearly show how the new option is an improvement (use test data)
  • Unit test coverage
  • Compliance with PEP 8
  • the PR has been reviewed and all comments are resolved
  • all CI checks pass
  • the PR description includes the phrase closes #<issue-number> to automatically close an issue
  • bug fixes, new features, or API changes are documented in whats_new.rst
  • Add my missing ORCID in the CITATION.cff file

@nabilalibou nabilalibou marked this pull request as draft April 14, 2024 13:16
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 97.42%. Comparing base (e4840d9) to head (1fc9fcc).

Files Patch % Lines
pyprep/find_noisy_channels.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   98.89%   97.42%   -1.48%     
==========================================
  Files           7        7              
  Lines         725      738      +13     
==========================================
+ Hits          717      719       +2     
- Misses          8       19      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant