-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Refactor assistant api #545
Merged
sashabaranov
merged 4 commits into
sashabaranov:master
from
henomis:fix/refactor-assistant-API
Nov 8, 2023
Merged
Fix Refactor assistant api #545
sashabaranov
merged 4 commits into
sashabaranov:master
from
henomis:fix/refactor-assistant-API
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 97.85% 97.88% +0.02%
==========================================
Files 20 20
Lines 978 991 +13
==========================================
+ Hits 957 970 +13
Misses 15 15
Partials 6 6
|
staugaard
approved these changes
Nov 7, 2023
sashabaranov
approved these changes
Nov 8, 2023
urjitbhatia
added a commit
to urjitbhatia/go-openai
that referenced
this pull request
Nov 8, 2023
sashabaranov
pushed a commit
that referenced
this pull request
Nov 13, 2023
* fix test server setup: - go map access is not deterministic - this can lead to a route: /foo/bar/1 matching /foo/bar before matching /foo/bar/1 if the map iteration go through /foo/bar first since the regex match wasn't bound to start and end anchors - registering handlers now converts * in routes to .* for proper regex matching - test server route handling now tries to fully match the handler route * add missing /v1 prefix to fine-tuning job cancel test server handler * add create message call * add messages list call * add get message call * add modify message call, fix return types for other message calls * add message file retrieve call * add list message files call * code style fixes * add test for list messages with pagination options * add beta header to msg calls now that #545 is merged * Update messages.go Co-authored-by: Simone Vellei <[email protected]> * Update messages.go Co-authored-by: Simone Vellei <[email protected]> * add missing object details for message, fix tests * fix merge formatting * minor style fixes --------- Co-authored-by: Simone Vellei <[email protected]>
maerlyn5
pushed a commit
to prassoai/go-openai
that referenced
this pull request
Nov 22, 2023
* fix test server setup: - go map access is not deterministic - this can lead to a route: /foo/bar/1 matching /foo/bar before matching /foo/bar/1 if the map iteration go through /foo/bar first since the regex match wasn't bound to start and end anchors - registering handlers now converts * in routes to .* for proper regex matching - test server route handling now tries to fully match the handler route * add missing /v1 prefix to fine-tuning job cancel test server handler * add create message call * add messages list call * add get message call * add modify message call, fix return types for other message calls * add message file retrieve call * add list message files call * code style fixes * add test for list messages with pagination options * add beta header to msg calls now that sashabaranov#545 is merged * Update messages.go Co-authored-by: Simone Vellei <[email protected]> * Update messages.go Co-authored-by: Simone Vellei <[email protected]> * add missing object details for message, fix tests * fix merge formatting * minor style fixes --------- Co-authored-by: Simone Vellei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Describe your solution
AssistantTool
type with optional sub fields.