Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Refactor assistant api #545

Merged

Conversation

henomis
Copy link
Contributor

@henomis henomis commented Nov 7, 2023

Describe the change

  • OpenAI Assistant API needs a Beta header
  • AssistantTool types can be simplified

Describe your solution

  • Add the header on Assistant APIs
  • use only AssistantTool type with optional sub fields.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #545 (8781188) into master (3063e67) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   97.85%   97.88%   +0.02%     
==========================================
  Files          20       20              
  Lines         978      991      +13     
==========================================
+ Hits          957      970      +13     
  Misses         15       15              
  Partials        6        6              
Files Coverage Δ
assistant.go 100.00% <100.00%> (ø)
chat.go 100.00% <ø> (ø)
chat_stream.go 100.00% <ø> (ø)
client.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sashabaranov sashabaranov merged commit a2d2bf6 into sashabaranov:master Nov 8, 2023
3 checks passed
urjitbhatia added a commit to urjitbhatia/go-openai that referenced this pull request Nov 8, 2023
sashabaranov pushed a commit that referenced this pull request Nov 13, 2023
* fix test server setup:
- go map access is not deterministic
- this can lead to a route: /foo/bar/1 matching /foo/bar before matching /foo/bar/1 if the map iteration go through /foo/bar first since the regex match wasn't bound to start and end anchors
- registering handlers now converts * in routes to .* for proper regex matching
- test server route handling now tries to fully match the handler route

* add missing /v1 prefix to fine-tuning job cancel test server handler

* add create message call

* add messages list call

* add get message call

* add modify message call, fix return types for other message calls

* add message file retrieve call

* add list message files call

* code style fixes

* add test for list messages with pagination options

* add beta header to msg calls now that #545 is merged

* Update messages.go

Co-authored-by: Simone Vellei <[email protected]>

* Update messages.go

Co-authored-by: Simone Vellei <[email protected]>

* add missing object details for message, fix tests

* fix merge formatting

* minor style fixes

---------

Co-authored-by: Simone Vellei <[email protected]>
maerlyn5 pushed a commit to prassoai/go-openai that referenced this pull request Nov 22, 2023
* fix test server setup:
- go map access is not deterministic
- this can lead to a route: /foo/bar/1 matching /foo/bar before matching /foo/bar/1 if the map iteration go through /foo/bar first since the regex match wasn't bound to start and end anchors
- registering handlers now converts * in routes to .* for proper regex matching
- test server route handling now tries to fully match the handler route

* add missing /v1 prefix to fine-tuning job cancel test server handler

* add create message call

* add messages list call

* add get message call

* add modify message call, fix return types for other message calls

* add message file retrieve call

* add list message files call

* code style fixes

* add test for list messages with pagination options

* add beta header to msg calls now that sashabaranov#545 is merged

* Update messages.go

Co-authored-by: Simone Vellei <[email protected]>

* Update messages.go

Co-authored-by: Simone Vellei <[email protected]>

* add missing object details for message, fix tests

* fix merge formatting

* minor style fixes

---------

Co-authored-by: Simone Vellei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants