chore: potential race fix

satisfactorymodding · Dec 21, 2023 · db1efc9 · db1efc9
1 parent ad5ef75
commit db1efc9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/cli/installations.go b/cli/installations.go
@@ -536,11 +536,14 @@ func (i *Installation) UpdateMods(ctx *GlobalContext, mods []string) error {
 func downloadAndExtractMod(modReference string, version string, link string, hash string, modsDirectory string, updates chan<- InstallUpdate, downloadSemaphore chan int, d disk.Disk) error {
 	var downloadUpdates chan utils.GenericProgress
 
+	var wg sync.WaitGroup
 	if updates != nil {
 		// Forward the inner updates as InstallUpdates
 		downloadUpdates = make(chan utils.GenericProgress)
 
+		wg.Add(1)
 		go func() {
+			defer wg.Done()
 			for up := range downloadUpdates {
 				updates <- InstallUpdate{
 					Item: InstallUpdateItem{
@@ -564,7 +567,6 @@ func downloadAndExtractMod(modReference string, version string, link string, has
 
 	var extractUpdates chan utils.GenericProgress
 
-	var wg sync.WaitGroup
 	if updates != nil {
 		// Forward the inner updates as InstallUpdates
 		extractUpdates = make(chan utils.GenericProgress)