perf(ftp): reduce number of ftp commands run in install preparation #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to an FTP server not on the same network, the latency for every FTP command being run greatly increases, slowing down the install process, which SMM frequently triggers.
Testing this using SirDigby's server, the latency was around 0.3s, and I observed 20 seconds being spent before even starting to extract mods. This PR reduces that time to ~5 seconds.
Improvements made:
Additionally,
.
and..
are ignored inReadDir
results, as non-standard FTP servers that useLIST -a
would return those too, leaving the possibility of the game dir being deleted if it contained a.smm
file