Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration of plugin #9

Merged

Conversation

dopplershift
Copy link
Contributor

According to the flake8 plugin docs, the entry point name should be the error code prefix that will be emitted from the plugin. Otherwise, apparently flake8 will silently discard messages. Fix that by registering under C801.

According to the flake8 plugin docs, the entry point name should be the
error code prefix that will be emitted from the plugin. Otherwise,
apparently flake8 will silently discard messages. Fix that by
registering under C801.
dopplershift added a commit to dopplershift/flake8-copyright-feedstock that referenced this pull request Mar 21, 2018
@dopplershift
Copy link
Contributor Author

@peterjc
Copy link

peterjc commented Jun 26, 2019

Does this fix #10?

@dopplershift
Copy link
Contributor Author

Possibly? Not sure what the root cause of #10 is.

@Paul-AUB
Copy link

Paul-AUB commented Apr 21, 2021

Tested with flake8==3.9.1, it works.

Without this fix, you must specify select = C in the config file (and it didn't work with extend-select). It's really a bargain as it doesn't work the same way as every other plugins which defaultly select their error codes when installed. So in my project I would need to know and select manually every code of every plugin...

I am very interrested in this fix, would it be considered to have a release with it ? (I see last activity in 2019)

@toofar
Copy link

toofar commented Aug 1, 2022

Looks like the plugin requires this change to work at all with flake 5.0, see PyCQA/flake8#325

I'm getting

There was a critical error during execution of Flake8:
plugin code for flake8-copyright[flake8_copyright] does not match ^[A-Z]{1,3}[0-9]{0,3}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants