Adjusted handling for big numbers in Portuguese and Spanish #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number it could handle, added new tests in Portuguese
|
@mrodriguezg1991 Tagging for review per Mohammed's email. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501 by adjusting the lows array in both Portuguese and Spanish files, so that the file no longer goes over the length of the array and incorrectly says that the inputted number is larger than the max value.
Changes proposed in this pull request:
Status
How to verify this change
Input any number between 0 - one nonillion to Spanish or Portuguese and ensure the translation is correct. Can also run the test file to verify this change in Portuguese.
Additional notes
This change edited the lows array because billions/quadrillions/sextillions in Spanish/Portuguese have the same root word as the power of ten before it, but with 'mil' added in front. EX in Spanish: (milion = "millón", billion = "mil millón", trillion = "billón", quadrillion = "mil billón").