Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Hindi language #607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryananderson
Copy link

Copied from stale PR here: #442

This is 100% the work of @pablohonney; that PR is over two years stale so I just started a fresh branch with the relevant parts and resolved the flake8/isort problems.

Changes proposed in this pull request:

  • add support for Hindi language
  • add tests

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

run tests

@coveralls
Copy link

Coverage Status

coverage: 98.05% (-0.002%) from 98.052%
when pulling b66644c on bryananderson:add-hindi
into 2b4d0bb on savoirfairelinux:master.

@bryananderson
Copy link
Author

Coveralls is failing because this line isn't covered. However, this line is currently unreachable for Hindi because all integers < 100 are in self.cards, so there is never a case where we need to merge two integers below 100.

Let me know if you prefer me to remove this elif altogether due to reduced coverage, or leave it in case future changes to lang_HI.py make the above assumption no longer hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants