Handle deserializeNodes dht protocol exception #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassdiass
force-pushed
the
HandledeserializeNodesDhtProtocolException
branch
from
70cbf67 to
1e8a0aa
Compare
…ageType::ValueUpdate if rsocket does not exist. processMessage called process out of try-catch
lucassdiass
force-pushed
the
HandledeserializeNodesDhtProtocolException
branch
from
1e8a0aa to
b21e922
Compare
…ype MessageType::ValueUpdate" This reverts commit b21e922.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a minor improvement. deserializeNodes method could throw exceptions and its call from the process method doesn't catch.