Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frontend network and use the default one instead. #832

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

erozqba
Copy link
Contributor

@erozqba erozqba commented Apr 8, 2018

Ref: issues 830

Fixes #830

Changes proposed in this pull request:

  • Remove not needed frontend network in favor of the default one.

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Manually spawn into one of the docker containers and verify that you don't get this warning
WARNING: Some networks were defined but are not used by any service: frontend

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.278% when pulling eb9d21d on erozqba:dev into 396f86d on savoirfairelinux:dev.

@kkonieczny
Copy link
Contributor

@kousu have you reviewed this PR as requested by @erozqba ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants