-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typeof
#4037
Open
toots
wants to merge
11
commits into
main
Choose a base branch
from
typeof
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add typeof
#4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm gonna wait for @smimram's opinion on this. There's to rush to merge but I think that it would be a great user-friendly feature. |
It would be a great user-friendly feature indeed) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
typeof <value>
type annotation.It has been proposed and scrapped several times but, recently, a pretty valid use-case popped up: #3760 (comment)
The idea being that
json
parsing is driven by the type but sometimes, describing a complex type is complicated and also hard to mainain.Instead, with this PR, it is possible to simply use your value and then ask to parse according to its type.
For instance, if you are storing data in a ref and wants to fetch the latest saved value, you can do:
Technical notes
The
typeof v
type annotation has to be converted to a type. It is done via alazy
value. The term referred to is kept in the closure of the lazy value and typechecked when the type is forced.typeof
type values are stored in the same facility as type variables. This is a bit hacky but it makes it safer as they can be dereferenced just like regular type variables, thus being part of the existing type API flow without much required change.