Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deviser tests documentation #41

Merged
merged 64 commits into from
Jan 21, 2021
Merged

Deviser tests documentation #41

merged 64 commits into from
Jan 21, 2021

Conversation

mattagape
Copy link
Contributor

I've gone through all the test files. Found a couple of issues. Please look at all the TODO comments (and all my comments anyway)!

Matthew Gillman added 30 commits December 15, 2020 12:10
A little simplification.
d069815
Documenting functions in run_matlab_tests.py.
6ea87b2
Tidyin gup a bit and adding function docstring.
31103f5
A bit more tidying.
2985780
Replace global_variables with gv.
7129b69
Started documenting test_functions.py.
9d328a5
Added more docstrings to test_functions.py.
08b3d3b
A little bit of tidying up.
a6818ca
Took out some common code.
2c37c22
Using os.path.normpath() means a file path should work on both Window…
4fd9bc7 
…s and *nix.
Now we can run more tests.
70abf42
More meaningful function name. Some tidying.
92e97b4
I've added docstrings to the functions I understand.
f128fa1
Final comment for now.
84a3ac8
Using os.path.normpath() means this should work on Windows and *nix.
74f1260
Extract common code into setup().
ec85fe2
Now we have a common compare function.
cdd8a3f
More generic functions to replace specifics.
32a8e3c
Finished documenting run_text_tests.py.
01fc802
Adding os.path.normpath() lets us run the tsts on Windows and *nix.
1071fac
Extracted common set-up code into its own function.
bc23d8f
Removed wrapper function around test_functions.compare_files().
b15acc2
Added some docstrings.
bd23dd7
Added what docstrings I can.
f2cae72
Added more text and TODO statements.
503e097
Used os.path.normpath() for portability.
c546a49
Finished most of the basic documentation for run_cmake_tests.py.
d17e055
Fixed some of the flake8 complaints.
a3c5485
Added more os.path.normpath() statements.
abe41fb
Added more os.path.normpath() statements to run_examples_tests.py, bu…
da46fb9 
…t I'm not sure if these particular ones are necessary.
Matthew Gillman added 17 commits January 6, 2021 17:17
Added explanatory note about dos2unix etc.
e45e104
Fixed some typos and flake8 complaints.
61b8ad5
Added os.path.normpath() statements to make the code portable.
32e6dbb
Moved a lot of duplicate code into new function common_set_up().
1efd1ca
Moved some common code into new function go_into_new_directory().
82abddd
Took out some more common code.
9844227
Took out some more common code into new comparison functions.
4ee0b16
import global_variables as gv
6ec4c25
Fixed a bug. Noted some failed and skipped tests.
8603651
Stopped most tests skipping.
2e36afc
Now we are no longer skipping tests.
3270d82
Now we are missing only two files.
bbe51fb
Now no files are missing.
03d9979
Started documenting run_other_library_tests.py
2a8e90d
Removed unused function parameter.
d59fd67
Added more docstrings, and also queries.
9035473
I think this is as much as I can do with this file.
15d895a
@mattagape mattagape requested a review from skeating January 12, 2021 09:23
skeating
skeating requested changes Jan 15, 2021
View reviewed changes
Copy link
Member

@skeating skeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments which hopefully explain enough for you tto fill in

generator/code_files/BaseClassFiles.py Outdated Show resolved Hide resolved
generator/code_files/ValidationFiles.py Outdated Show resolved Hide resolved
generator/code_files/ValidationFiles.py Outdated Show resolved Hide resolved
generator/tests/run-tests.py Outdated Show resolved Hide resolved
generator/tests/run-tests.py Show resolved Hide resolved
generator/tests/test_other_library/run_other_library_tests.py Outdated Show resolved Hide resolved
generator/tests/test_other_library/run_other_library_tests.py Outdated Show resolved Hide resolved
generator/tests/test_other_library/run_other_library_tests.py Outdated Show resolved Hide resolved
generator/tests/test_other_library/run_other_library_tests.py Outdated Show resolved Hide resolved
generator/tests/test_tex_files/run_tex_tests.py Outdated Show resolved Hide resolved
@skeating skeating self-requested a review January 19, 2021 09:35
@mattagape mattagape merged commit c10d25d into develop Jan 21, 2021
@mattagape mattagape deleted the matt-tests branch January 21, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeating skeating skeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattagape @skeating