improve error handling when a url/homepage is invalid #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since sbt#134, encountering an 'invalid' URI such as `https://github.com/rnorth/${project.artifactId}` from https://github.com/rnorth/duct-tape would throw an error and fail the entire job. As the user of the plugin likely doesn't have direct influence over the `pom.xml` of the dependencies, it would be better to emit a warning. With this change, it becomes: ``` sbt-license-report: dependency [org.rnorth.duct-tape:duct-tape:1.0.8] has malformed homepage url [https://github.com/rnorth/${project.artifactId}] ``` This improves the situation described in sbt#144. I'm not sure it is a full fix, because I'm not sure `https://github.com/rnorth/${project.artifactId}` is actually invalid here: I haven't checked whether maven placeholders are allowed here, and if so, whose responsibility it is to make sure they get resolved.
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #134, encountering an 'invalid' URI such as
https://github.com/rnorth/${project.artifactId}from https://github.com/rnorth/duct-tape would throw an error and fail the entire job. As the user of the plugin likely doesn't have direct influence over thepom.xmlof the dependencies, it would be better to emit a warning. With this change, it becomes:This improves the situation described in #144.
I'm not sure it is a full fix, because I'm not sure
https://github.com/rnorth/${project.artifactId}is actually invalid here: I haven't checked whether maven placeholders are allowed here, and if so, whose responsibility it is to make sure they get resolved (see #92 for that aspect).