Style Guide update #3122
Open
Style Guide update #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkepka
commented
Dec 9, 2024
Comment on lines
-82
to
-86
| The exceptions to this rule are `for`-comprehensions which lack a | ||
| `yield` clause. In such cases, the construct is actually a loop rather | ||
| than a functional comprehension and it is usually more readable to | ||
| string the generators together between parentheses rather than using the | ||
| syntactically-confusing `} {` construct: |
There was a problem hiding this comment.
I suggest to drop this since the arguments for using one-generator-per-line syntax hold no matter whether the next keyword is do or yield
gkepka
commented
Dec 9, 2024
Comment on lines
-14
to
-15
| As a rule, files should contain a *single* logical compilation unit. By | ||
| "logical" I mean a class, trait or object. One exception to this |
There was a problem hiding this comment.
This resolves #1621 by removing the confusing concept entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.