drop sbt 1.3.x support & speedup CI by parallelizing scripted #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
dropsbt13
branch
4 times, most recently
from
a9ee330 to
5186725
Compare
bjaglin
force-pushed
the
dropsbt13
branch
12 times, most recently
from
dae31f4 to
aa7033a
Compare
Closed
bjaglin
commented
Apr 23, 2024
| @@ -73,6 +73,8 @@ scalacOptions ++= List( | |||
| enablePlugins(ScriptedPlugin) | |||
| sbtPlugin := true | |||
| scriptedBufferLog := false | |||
| scriptedBatchExecution := true | |||
There was a problem hiding this comment.
despite the intent of sbt/sbt#6151, scriptedBatchExecution is never true by default (because binVersion is "1" on sbt 1.x)
bjaglin
changed the title
bjaglin
changed the title
bjaglin
force-pushed
the
dropsbt13
branch
2 times, most recently
from
9eac61b to
afdf5e3
Compare
bjaglin
changed the title
bjaglin
force-pushed
the
dropsbt13
branch
2 times, most recently
from
fde3f81 to
87e05d2
Compare
bjaglin
commented
Apr 24, 2024
| @@ -73,8 +73,9 @@ scalacOptions ++= List( | |||
| enablePlugins(ScriptedPlugin) | |||
| sbtPlugin := true | |||
| scriptedBufferLog := false | |||
| scriptedBatchExecution := true | |||
| scriptedParallelInstances := 2 | |||
There was a problem hiding this comment.
I tried 4 initially, but it brings transient failures on CI (every other run roughly...). Anyway, it seems slower overall when it passes, probably because of increased CPU/memory pressure, as standard VMs are 4 vCPU/16GB, and we request 4GB heap for the main process and 2GB per scripted batch.
bjaglin
force-pushed
the
dropsbt13
branch
16 times, most recently
from
c137041 to
749823f
Compare
bjaglin
force-pushed
the
dropsbt13
branch
2 times, most recently
from
a8d98c5 to
0dc413b
Compare
bjaglin
commented
Aug 13, 2024
| @@ -40,14 +45,17 @@ jobs: | |||
| - uses: coursier/setup-action@v1 | |||
| with: | |||
| jvm: temurin:21 | |||
| - run: sbt "test; scripted sbt-scalafix/* skip-windows/*" | |||
There was a problem hiding this comment.
sbt-1.5/* was ignored on JDK21 until now. The fix was simply to bump a compatible scala 3 version (per the compatibility matrix).
bjaglin
changed the title
scriptedBatchExecution effectively ignores custom build.properties, so this takes a different approach, running one sbt version per execution, spread over JDK versions for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Why can we do it?
TODO