Add Scoverage plugin, coverage check into CI #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the highlights of this release: * Faster Kotlin DSL script compilation * Vendor selection for Java toolchains * Convenient execution of tasks in composite builds * Consistent dependency resolution
Closed
|
Also, in 7a91a29 we updated the most recent version. This brings some optimization, among which a faster Kotlin DSL script compilation, and do not "brokes" our code, so it's all good for us 📈 |
Closed
ThomasAngeliniUnibo
approved these changes
Feb 1, 2021
Closed
maldins46
changed the title
|
After various attempts, we managed to set up Scoverage into the project, disabling the parallel build feature (as does not give too many advantages to the build time). Now the ci workflows also check the coverage threshold after tests. Provisionally, the threshold is set to 0, but after finishing the test on CLI we should reach 75% coverage into cli and core. |
# Conflicts: # versions.properties
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to solve part of the projects indicated in #52.
Following further researches, Jacoco is not an optimal solution for detecting the code coverage in Scala. Even though it gives you a coverage rate number, Jacoco knows nothing about Scala, and therefore it doesn’t tell you which piece of code you forgot to cover (as stated here).
An optimal solution could be using Scoverage, a tool thought explicitly for Scala code coverage analysis, a state-of-the-art technology for Scala projects. Anyway, we found that this tool presents a problem when used in multi-project parallel builds with Gradle 6.7+ (as our project is), therefore it could not be used at the moment.
Waiting for a better solution, we prepared a "patch" solution, including Jacoco support for the project, without embedding controls into the CI workflow. This way we can trigger a minimum of manual coverage control:
jacocoTestReporttask, to build and visualize human-readable text reports for the project;jacocoTestCoverageVerificationtask, to check that the coverage is higher than a given coverage threshold. We have chosen a low threshold, on class coverage only (60% coverage), as with the mentioned above limitations, is a passable one, even if not very truthy.