Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inference): add tutorial how to implement RAG with managed infer… #3744

Merged
merged 27 commits into from
Oct 4, 2024

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Sep 24, 2024

Description

A tutorial for inference to.known: how to implement Retrieval-Augmented Generation (RAG) using Scaleway's managed inference, PostgreSQL, pgvector, and object storage.

@Laure-di Laure-di marked this pull request as draft September 24, 2024 13:32
@Laure-di Laure-di self-assigned this Sep 24, 2024
@Laure-di Laure-di requested a review from bene2k1 September 24, 2024 13:33
@github-actions github-actions bot added the status: draft Work in progress - do not merge or review label Sep 24, 2024
@Laure-di Laure-di requested a review from tgenaitay September 24, 2024 13:33
@Laure-di Laure-di force-pushed the int-add-inference branch 2 times, most recently from 255e7ec to 752d1a8 Compare September 24, 2024 14:13
@Laure-di Laure-di force-pushed the int-add-inference branch 2 times, most recently from 4328de4 to 6ba5ea2 Compare September 24, 2024 14:36
@Laure-di Laure-di force-pushed the int-add-inference branch 4 times, most recently from 73c7b8c to 003a3b6 Compare September 24, 2024 15:49
@Laure-di Laure-di force-pushed the int-add-inference branch 6 times, most recently from 66e5b1c to 3609f75 Compare September 26, 2024 09:10
Copy link
Contributor

@tgenaitay tgenaitay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first version!
Thoughts

  1. I couldn't follow as it was unclear where each piece of code should go. I mean, past the .env file, I'm left with python snippets all around. Perhaps we can split into what's setup, and what goes into a python file.
  2. I believe some of the .env variables are not used.
  3. I believe we are not using the scaleway sdk and wonder why invoking it
  4. The tutorial is around langchain, so I think its key components should be introduced (watch out I believe one is deprecated already)
  5. Overall to be very practical it would be ideal in the end to have a functioning RAG. The critical thing I'm missing is perhaps a fileset I can really import so that I get a "wow" effect in last chapter. Without this element, I wouldn't reach the goal you have set as "What are the commands to set up XX with the CLI of Scaleway?"

tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
@Laure-di Laure-di force-pushed the int-add-inference branch 4 times, most recently from abc4837 to 53c2aa9 Compare September 27, 2024 13:01
@Laure-di Laure-di force-pushed the int-add-inference branch 6 times, most recently from fcfcb0c to 709786d Compare October 4, 2024 09:19
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
Laure-di and others added 2 commits October 4, 2024 03:50
@Laure-di Laure-di marked this pull request as ready for review October 4, 2024 10:56
@github-actions github-actions bot removed the status: draft Work in progress - do not merge or review label Oct 4, 2024
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
tutorials/how-to-implement-rag/index.mdx Outdated Show resolved Hide resolved
@bene2k1 bene2k1 merged commit f3a7875 into scaleway:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants