Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(instance): fix ssh config install tests #4370

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 18, 2024

I made some change in another PR to avoid creating IPs with servers in tests. This broke ssh config tests.

@Codelax Codelax added instance Instance issues, bugs and feature requests tests labels Dec 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (5bf53e0) to head (a6e0971).
Report is 399 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4370      +/-   ##
==========================================
- Coverage   75.45%   70.88%   -4.58%     
==========================================
  Files         202      295      +93     
  Lines       44323    65533   +21210     
==========================================
+ Hits        33444    46453   +13009     
- Misses       9653    17449    +7796     
- Partials     1226     1631     +405     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Dec 18, 2024
Merged via the queue into scaleway:master with commit b7f2a90 Dec 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants