Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): white space #4572

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(Text): white space #4572

wants to merge 2 commits into from

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Feature

Summarise concisely:

What is expected?

<Text />: new prop whiteSpace

The following changes were made:

  1. Added a new prop

  2. Used the new prop in various Ultraviolet components (Snippet, Navigation...)

@lisalupi lisalupi self-assigned this Dec 11, 2024
@lisalupi lisalupi requested a review from matthprost as a code owner December 11, 2024 14:44
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: e84be8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (e11aa60) to head (e84be8f).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4572      +/-   ##
==========================================
+ Coverage   87.51%   87.59%   +0.07%     
==========================================
  Files         335      335              
  Lines       12762    12806      +44     
  Branches     3510     3487      -23     
==========================================
+ Hits        11169    11217      +48     
+ Misses       1593     1589       -4     
Files with missing lines Coverage Δ
packages/ui/src/components/Badge/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Snippet/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Stepper/Step.tsx 97.53% <ø> (ø)
...es/ui/src/components/Text/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Text/index.tsx 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb2c06...e84be8f. Read the comment docs.

Comment on lines 21 to +22
type PlacementProps = React.CSSProperties['textAlign']
type WhiteSpaceProps = React.CSSProperties['whiteSpace']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was there before but we avoid React. in our code base, instead you can import CSSProperties from react above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants