-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Text): white space #4572
base: main
Are you sure you want to change the base?
feat(Text): white space #4572
Conversation
🦋 Changeset detectedLatest commit: e84be8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4572 +/- ##
==========================================
+ Coverage 87.51% 87.59% +0.07%
==========================================
Files 335 335
Lines 12762 12806 +44
Branches 3510 3487 -23
==========================================
+ Hits 11169 11217 +48
+ Misses 1593 1589 -4
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
type PlacementProps = React.CSSProperties['textAlign'] | ||
type WhiteSpaceProps = React.CSSProperties['whiteSpace'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it was there before but we avoid React.
in our code base, instead you can import CSSProperties from react above
Summary
Type
Summarise concisely:
What is expected?
<Text />
: new propwhiteSpace
The following changes were made:
Added a new prop
Used the new prop in various Ultraviolet components (Snippet, Navigation...)