Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocC fix #645

Closed
wants to merge 1 commit into from
Closed

DocC fix #645

wants to merge 1 commit into from

Conversation

MasterWatcher
Copy link

There are two problems with the documentation:

  1. init parameters offset in FloatingPanelAdaptiveLayoutAnchor and FloatingPanelIntrinsicLayoutAnchor named by argument label (absoluteOffset and fractionalOffset).
  2. init parameters of FloatingPanelLayoutAnchoring named absoluteOffset instead of absoluteInset and fractionalOffset instead of fractionalInset accordingly.

The main problem occurs when we try to use FloatingPanel in Objective-c code. FloatingPanel-Swift.h header contains the errors and the framework can't be compiled.

Screenshot 2024-09-04 at 17 27 55

@MasterWatcher
Copy link
Author

@scenee

@scenee
Copy link
Owner

scenee commented Sep 6, 2024

Thank you for your contribution. However, I have already created a patch with PR #644, so please let me close this one. Thanks.

@scenee scenee closed this Sep 6, 2024
@MasterWatcher
Copy link
Author

Awesome! When can we expect the release of the new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants