Feature/extract concat strings #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 1, 2016 09:45
|
This is replacing #336 I'm not sure about the part "It only adds the ability to handle concatenated strings to regular php files. Is it not possible to support this with other files like the form extractor?" I haven't used that feature but I can add the fix there too, I would need some details though on where to add the fix, is it only affecting FormExtractor class? Or it should be added in other places too? |
| @@ -216,7 +216,7 @@ public function extract() | |||
| if (false !== $pos = strrpos($file, '.')) { | |||
| $extension = substr($file, $pos + 1); | |||
|
|
|||
| if ('php' === $extension) { | |||
| if ('php' === $extension or 'phtml' === $extension) { | |||
|
I like this PR, I only had some questions |
| if ($node instanceof String_) { | ||
| return $node->value; | ||
| } else { | ||
| return self::concatToString($node->left) . self::concatToString($node->right); |
|
ping @murhafh, you still looking to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just added a small change so in case you have a long concatenated strings in your code, you can use the bundle to extract those strings into your translation files. It basically converts the concatenated strings into one string before passing it to extraction.
Todos