Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 and return (un)suppressed findings #20

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Python 3.11 and return (un)suppressed findings #20

merged 7 commits into from
Oct 2, 2024

Conversation

mlflr
Copy link
Contributor

@mlflr mlflr commented Oct 2, 2024

This PR has 2 changes:

  • Migrate to Python 3.11 since 3.8 will be EOL
  • Instead of returning a boolean showing success/failure returns a tuple returning the same boolean and a list of (un)suppressed findings
    • Unit Tests now verify results using the output instead of arguments of mocked calls

Note: the library works on 3.12, but Prospector (linter) does not. There are PRs open to fix those issues, but the main maintainer is not responding and other collaborators don't want to approve them due to lack of knowledge...

costastf
costastf approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@costastf costastf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@costastf costastf merged commit 31fb56a into schubergphilis:main Oct 2, 2024
2 checks passed
@mlflr mlflr deleted the feature/python311-and-return-suppressed-findings branch October 2, 2024 19:14
costastf pushed a commit that referenced this pull request Oct 4, 2024
Revert "Python 3.11 and return (un)suppressed findings (#20)"
cca91e9 
This reverts commit 31fb56a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costastf costastf costastf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlflr @costastf