-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: [#100] Prevent code duplication by using a Taskfile
- Loading branch information
Showing
3 changed files
with
134 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| # TASK_X_REMOTE_TASKFILES=1 task remote:lint | ||
| # cmd: steps that will be run sequentially | ||
| # deps: tasks that will be run in parallel | ||
| --- | ||
| version: "3" | ||
|
|
||
| vars: | ||
| GCI_VERSION: 0.13.5 | ||
| GOLANGCI_LINT_VERSION: 1.61.0 | ||
|
|
||
| tasks: | ||
| gci-install: | ||
| silent: true | ||
| cmds: | ||
| - | | ||
| if ! ~/go/bin/gci --version | grep -q "gci version {{.GCI_VERSION}}"; then | ||
| go install github.com/daixiang0/gci@v{{.GCI_VERSION}} | ||
| fi | ||
| gci: | ||
| silent: true | ||
| cmds: | ||
| - task: gci-install | ||
| - | | ||
| if ~/go/bin/gci list --skip-generated . | grep "\.go$"; then | ||
| echo "One or more golang files detected with: 'incorrect import order':" | ||
| echo " * Observe: '~/go/bin/gci diff --skip-generated .'" | ||
| echo " * Resolve: '~/go/bin/gci write --skip-generated .'" | ||
| exit 1 | ||
| fi | ||
| gci-write: | ||
| silent: true | ||
| cmds: | ||
| - task: gci-install | ||
| - ~/go/bin/gci write --skip-generated -s standard -s default . | ||
| golangci-lint-install: | ||
| silent: true | ||
| cmds: | ||
| - | | ||
| if ! golangci-lint --version | grep -q "has version {{.GOLANGCI_LINT_VERSION}}"; then | ||
| curl \ | ||
| -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh |\ | ||
| sh -s -- -b $(go env GOPATH)/bin v{{.GOLANGCI_LINT_VERSION}} | ||
| fi | ||
| golangci-lint-run: | ||
| silent: true | ||
| cmds: | ||
| - | | ||
| golangci-lint run \ | ||
| --build-tags component,e2e,integration \ | ||
| --timeout 2m30s \ | ||
| --verbose | ||
| golangci-lint: | ||
| silent: true | ||
| cmds: | ||
| - task: golangci-lint-install | ||
| - task: golangci-lint-run | ||
| golangci-lint-run-without-cache: | ||
| silent: true | ||
| cmds: | ||
| - task: golangci-lint-install | ||
| - golangci-lint cache clean | ||
| - task: golangci-lint-run | ||
| lint: | ||
| silent: true | ||
| deps: | ||
| - task: gci | ||
| - task: golangci-lint | ||
| test: | ||
| silent: true | ||
| cmds: | ||
| - | | ||
| if [ "$(uname -s)" = "Darwin" ]; then | ||
| GOLANG_PARALLEL_TESTS=$(sysctl -n hw.ncpu) | ||
| else | ||
| GOLANG_PARALLEL_TESTS=$(nproc) | ||
| fi | ||
| echo "GOLANG_PARALLEL_TESTS: ${GOLANG_PARALLEL_TESTS}" | ||
| echo "BLA {{.TEST_ARGS}} {{.CLI_ARGS}}" | ||
| go test \ | ||
| -p "${GOLANG_PARALLEL_TESTS}" \ | ||
| -race \ | ||
| -short \ | ||
| --tags="{{.TEST_TAGS}}" | ||
| -v #\ | ||
| # $(go list {{.TEST_TAGS}} ./... | grep -v {{.CLI_ARGS}}) | ||
| # # $COVERPKG \ | ||
| # # $COVERPROFILE \ | ||
| # # $TAGS \ | ||
| # # $(echo "{{.CLI_ARGS}}") | ||
| test-component: | ||
| silent: true | ||
| cmds: | ||
| - task: test | ||
| vars: | ||
| TEST_ARGS: >- | ||
| -e MCVS_SCANNER_LOGGING_LEVEL={{.TASK_DOCKER_LOGGING_LEVEL}} | ||
| TEST_TAGS: component | ||
| test-integration: | ||
| silent: true | ||
| cmds: | ||
| - task: test | ||
| vars: | ||
| TEST_ARGS: >- | ||
| -e MCVS_SCANNER_LOGGING_LEVEL={{.TASK_DOCKER_LOGGING_LEVEL}} | ||
| TEST_EXCLUSIONS: | ||
| TEST_TAGS: integration |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ name: mcvs-golang-action | |
| description: | | ||
| The Mission Critical Vulnerability Scanner (MCVS) Golang action. | ||
| inputs: | ||
| code_coverage_expected: | ||
| code-coverage-expected: | ||
| default: "80" | ||
| description: | | ||
| The minimum code coverage. | ||
|
|
@@ -22,6 +22,10 @@ inputs: | |
| golang-number-of-tests-in-parallel: | ||
| description: | | ||
| Number of test in parallel. | ||
| task-version: | ||
| default: v3.39.2 | ||
| description: | | ||
| The Task version that has to be installed and used. | ||
| testing-type: | ||
| description: | | ||
| The testing type, e.g. integration, unit or some other. | ||
|
|
@@ -42,22 +46,23 @@ runs: | |
| using: "composite" | ||
| steps: | ||
| # | ||
| # YAML linting. | ||
| # | ||
| - run: | | ||
| pip install --user yamllint==1.35.1 | ||
| yamllint -d '{extends: default, rules: {comments: {min-spaces-from-content: 1}}}' . | ||
| if: inputs.testing-type == 'lint' | ||
| shell: bash | ||
| # | ||
| # Install the golang version that has been defined in the go.mod file. | ||
| # Install task and the golang version that has been defined in the go.mod | ||
| # file. | ||
| # | ||
| # yamllint disable rule:line-length | ||
| - uses: actions/[email protected] | ||
| if: inputs.testing-type == 'component' || inputs.testing-type == 'coverage' || inputs.testing-type == 'integration' || inputs.testing-type == 'unit' | ||
| if: inputs.testing-type == 'component' || inputs.testing-type == 'coverage' || inputs.testing-type == 'integration' || inputs.testing-type == 'lint' || inputs.testing-type == 'unit' | ||
| with: | ||
| go-version-file: "go.mod" | ||
| cache: false | ||
| - name: install task | ||
| if: inputs.testing-type == 'component' || inputs.testing-type == 'coverage' || inputs.testing-type == 'integration' || inputs.testing-type == 'lint' || inputs.testing-type == 'unit' | ||
| shell: bash | ||
| run: | | ||
| if ! ~/go/bin/task --version | grep "Task version: ${{ inputs.task-version }}"; then | ||
| major_version=$(echo "${{ inputs.task-version }}" | sed -E 's/^v([0-9]+).*/\1/') | ||
| go install github.com/go-task/task/v${major_version}/cmd/task@${{ inputs.task-version }} | ||
| fi | ||
| # yamllint enable rule:line-length | ||
| # | ||
| # Verify downloaded dependencies. | ||
|
|
@@ -80,14 +85,10 @@ runs: | |
| - name: gci | ||
| if: inputs.gci == 'true' && inputs.testing-type == 'lint' | ||
| shell: bash | ||
| env: | ||
| TASK_X_REMOTE_TASKFILES: 1 | ||
| run: | | ||
| go install github.com/daixiang0/[email protected] | ||
| if ~/go/bin/gci list --skip-generated . | grep "\.go$"; then | ||
| echo "One or more golang files detected with: 'incorrect import order':" | ||
| echo " * Observe: '~/go/bin/gci diff --skip-generated .'" | ||
| echo " * Resolve: '~/go/bin/gci write --skip-generated .'" | ||
| exit 1 | ||
| fi | ||
| task remote:golangci-lint --yes | ||
| # | ||
| # Code security scanning. | ||
| # | ||
|
|
@@ -145,28 +146,20 @@ runs: | |
| # Run golangci-lint. | ||
| # | ||
| - name: golangci-lint | ||
| uses: golangci/[email protected] | ||
| if: inputs.testing-type == 'lint' | ||
| with: | ||
| args: |- | ||
| --enable-all \ | ||
| --out-format=colored-line-number \ | ||
| --timeout 2m30s \ | ||
| -v | ||
| version: ${{ inputs.golangci-lint-version }} | ||
| shell: bash | ||
| env: | ||
| TASK_X_REMOTE_TASKFILES: 1 | ||
| run: | | ||
| task remote:golangci-lint --yes | ||
| # | ||
| # Unit tests. | ||
| # | ||
| - name: unit tests | ||
| if: inputs.testing-type == 'unit' | ||
| shell: bash | ||
| run: | | ||
| ${GITHUB_ACTION_PATH}/src/go-test.sh \ | ||
| "" \ | ||
| "" \ | ||
| "${{ inputs.golang-number-of-tests-in-parallel }}" \ | ||
| "${{ inputs.golang-unit-tests-exclusions }}" \ | ||
| "" | ||
| task remote:test --yes | ||
| # | ||
| # Integration tests. | ||
| # | ||
|
|
||