fix: [#87] Optional GCI (#88)

schubergphilis · Oct 21, 2024 · b29a297 · b29a297
1 parent 32d0d6c
commit b29a297
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -51,6 +51,7 @@ and a [.golangci.yml](https://golangci-lint.run/usage/configuration/).
 | Option                             | Default                              | Required | Description                                                                                                      |
 | :--------------------------------- | :----------------------------------- | -------- | :--------------------------------------------------------------------------------------------------------------- |
 | code_coverage_expected             | 80                                   |          |                                                                                                                  |
+| gci                                | true                                 |          | Check for 'incorrect import order'. If failed then instructions are shown to resolve the issue                   |
 | golang-unit-tests-exclusions       | ' '                                  |          |                                                                                                                  |
 | golangci-lint-version              | v1.55.2                              |          |                                                                                                                  |
 | golang-number-of-tests-in-parallel | 4                                    |          |                                                                                                                  |

diff --git a/action.yml b/action.yml
@@ -4,17 +4,21 @@ description: |
   The Mission Critical Vulnerability Scanner (MCVS) Golang action.
 inputs:
   code_coverage_expected:
+    default: "80"
     description: |
       The minimum code coverage.
-    default: "80"
+  gci:
+    default: "true"
+    description: |
+      Whether to check gci. Disable if the project provides an alternative way.
   golang-unit-tests-exclusions:
+    default: " "
     description: |
       The Golang paths that should be excluded from unit testing.
-    default: " "
   golangci-lint-version:
+    default: v1.55.2
     description: |
       The Golangci-lint version that has to be installed and used.
-    default: v1.55.2
   golang-number-of-tests-in-parallel:
     description: |
       Number of test in parallel.
@@ -65,6 +69,7 @@ runs:
     # but it does not provide clarity how to resolve it when positive.
     #
     - name: gci
+      if: inputs.gci == 'true'
       shell: bash
       run: |
         go install github.com/daixiang0/[email protected]
@@ -85,11 +90,17 @@ runs:
         severity-cutoff: high
     - uses: 030/[email protected]
     - name: Log in to GitHub Packages Docker registry
+      if: inputs.token != ''
       shell: bash
       run: |
         echo "${{ inputs.token }}" |\
           docker login ghcr.io -u ${{ github.actor }} --password-stdin
+    #
+    # Duplicated trivy-action parameters as dependabot does NOT support
+    # anchors: https://github.com/actions/runner/issues/1182
+    #
     - uses: aquasecurity/[email protected]
+      if: inputs.token != ''
       env:
         TRIVY_DB_REPOSITORY: ${{ inputs.trivy-action-db }}
         TRIVY_JAVA_DB_REPOSITORY: ${{ inputs.trivy-action-java-db }}
@@ -102,6 +113,18 @@ runs:
         ignore-unfixed: true
         severity: "CRITICAL,HIGH"
         trivyignores: .trivyignore
+    - uses: aquasecurity/[email protected]
+      if: inputs.token == ''
+      env:
+        TRIVY_DB_REPOSITORY: ${{ inputs.trivy-action-db }}
+        TRIVY_JAVA_DB_REPOSITORY: ${{ inputs.trivy-action-java-db }}
+      with:
+        scan-type: "fs"
+        scan-ref: "."
+        exit-code: "1"
+        ignore-unfixed: true
+        severity: "CRITICAL,HIGH"
+        trivyignores: .trivyignore
     #
     # Run golangci-lint.
     #