Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#124] Make variables that are required, mandatory #125

Closed
wants to merge 1 commit into from
Closed

fix: [#124] Make variables that are required, mandatory #125

wants to merge 1 commit into from

Conversation

sbp-bvanb
Copy link
Collaborator

@sbp-bvanb sbp-bvanb commented Nov 13, 2024 •
edited
Loading

Ensure that variables are set by using requires. If not then bad things can happen.

@sbp-bvanb sbp-bvanb linked an issue Nov 13, 2024 that may be closed by this pull request
If var then requires should be used to ensure that variables are non-empty #124
Closed
@sbp-bvanb
Copy link
Collaborator Author

There was a conversation and the requires will be used only when it is really needed to prevent that disastrous things will happen on a machine if some variables would be omitted.

@sbp-bvanb sbp-bvanb closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jherrerasbp jherrerasbp jherrerasbp approved these changes

@pietergdp pietergdp Awaiting requested review from pietergdp

@markvl-sbp markvl-sbp Awaiting requested review from markvl-sbp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If var then requires should be used to ensure that variables are non-empty
2 participants
@sbp-bvanb @jherrerasbp