Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore JSON when running OPA as it only supports rego #145

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

sbp-bvanb
Copy link
Collaborator

@sbp-bvanb sbp-bvanb commented Dec 9, 2024

This pull request includes changes to the Taskfile.yml to improve the handling of OPA tests by centralizing the OPA command into a variable. This change aims to simplify the command execution and make the script more maintainable.

Improvements to OPA test command handling:

  • Taskfile.yml: Introduced a new variable opa_cmd to store the OPA test command and updated the script to use this variable for running tests, displaying explanations, and generating code coverage overview.
  • JSON files have to be ignored to prevent "merge" errors while running OPA.

Copy link
Contributor

@markvl-sbp markvl-sbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the change itself, but do find it a bit sad that the AI generated description of this PR doesn't even mention the (IMHO) most important bit of this PR: that you are ignoring the .json files when running opa test. 🤷‍♂️

@sbp-bvanb
Copy link
Collaborator Author

I approve the change itself, but do find it a bit sad that the AI generated description of this PR doesn't even mention the (IMHO) most important bit of this PR: that you are ignoring the .json files when running opa test. 🤷‍♂️

You are right. I will update it.

@sbp-bvanb sbp-bvanb merged commit 6e93f96 into main Dec 10, 2024
3 checks passed
@sbp-bvanb sbp-bvanb deleted the opa-ignore-json branch December 10, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants