Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lint and unit tests require a token sometimes for getting required binaries #149

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sbp-bvanb
Copy link
Collaborator

@sbp-bvanb sbp-bvanb commented Dec 13, 2024

This pull request includes updates to the README.md and action.yml files to improve documentation and enhance the configuration of GitHub Actions for the project. The most important changes include the addition of a new input for downloading private Go modules, updates to the formatting of tables in the README, and changes to the environment variables used in the GitHub Actions workflow.

Documentation updates:

  • README.md: Improved formatting of tables and added a new option for github-token-for-downloading-private-go-modules in the list of variables. [1] [2]

GitHub Actions configuration:

  • action.yml: Added a new input for github-token-for-downloading-private-go-modules to handle private Go modules.
  • action.yml: Updated the GitHub Actions workflow to configure Git with the new input for downloading private Go modules.
  • action.yml: Changed the environment variable from TASK_X_REMOTE_TASKFILES to GITHUB_TOKEN for running remote tasks in the lint and unit test steps. [1] [2]

@sbp-bvanb sbp-bvanb force-pushed the lint-unit-require-token branch from 7027cd9 to 910ae60 Compare December 13, 2024 12:21
@sbp-bvanb sbp-bvanb merged commit 1eb8f43 into main Dec 13, 2024
2 checks passed
@sbp-bvanb sbp-bvanb deleted the lint-unit-require-token branch December 13, 2024 13:29
@sbp-bvanb sbp-bvanb linked an issue Dec 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private modules
2 participants