Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Omit ~/go/bin from task #151

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: Omit ~/go/bin from task #151

merged 1 commit into from
Dec 13, 2024

Conversation

sbp-bvanb
Copy link
Collaborator

@sbp-bvanb sbp-bvanb commented Dec 13, 2024

This pull request includes changes to the Taskfile.yml and action.yml files to improve the handling of the GOBIN environment variable and streamline the task version check. The most important changes include adding conditional logic for GOBIN in GitHub Actions, updating task commands to echo GOBIN, and simplifying the task version check in the GitHub Action workflow.

Improvements to GOBIN handling:

  • Taskfile.yml: Added conditional logic to set GOBIN to /home/runner/go/bin if running in GitHub Actions.
  • Taskfile.yml: Updated task commands to echo the value of GOBIN for better visibility during execution. [1] [2]

Streamlining task version check:

  • action.yml: Simplified the task version check by removing the hardcoded path to the task binary and relying on the system's PATH.

README.md Outdated Show resolved Hide resolved
@sbp-bvanb sbp-bvanb force-pushed the go-bin-task branch 4 times, most recently from 1e2428c to 3635d01 Compare December 13, 2024 15:21
@sbp-bvanb sbp-bvanb merged commit 250a880 into main Dec 13, 2024
1 check passed
@sbp-bvanb sbp-bvanb deleted the go-bin-task branch December 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants