-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable stub server #4
Conversation
dfe5abf
to
b671c89
Compare
9751e6e
to
760c550
Compare
Could you extend the README by adding an example you have provided in the description of this PR? |
Done. Also simplified the docker file. Now the only thing that remains is adjusting the docker GH action to receive different build args. |
f0e9a86
to
f9b898e
Compare
f9b898e
to
e962e08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Dockerfile
can be improved slightly, but nothing to keep this PR from being merged as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time for detailed look, but some comments nonetheless. If I had more time I'd take a close look at that any in Response
and map value in endpoints
to see how it's used and if we can make a non-empty interface from that.
Add a configurable stub server.
Configuring
Hit a configured endpoint