feat: Add PostgreSQL support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
Using PostgreSQL with this module was always possible but required overriding defaults as this module was geared towards MySQL as a default. Noticeable changes: * `var.engine` is now required and only allows `mysql` or `postgresql` as these are the only two Aurora types * Other variables that defaulted to MySQL values have been removed and replaced with a default per engine and allow overriding using the user facing variable (e.g. `master_username` defaults to an engine specific value whilst still letting the user set their own if they so desire) * Added more variable validation Signed-off-by: Stephen Hoekstra <[email protected]>
shoekstra
force-pushed
the
add_postgres_support
branch
from
743b260 to
e6ab10b
Compare
marwinbaumannsbp
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using PostgreSQL with this module was always possible but required overriding defaults as this module was geared towards MySQL as a default.
Noticeable changes:
var.engineis now required and only allowsmysqlorpostgresqlas these are the only two Aurora typesmaster_usernamedefaults to an engine specific value whilst still letting the user set their own if they so desire)Signed-off-by: Stephen Hoekstra [email protected]