Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Improve docs and validations #8

Merged
merged 9 commits into from
Dec 23, 2024
Merged

enhancement: Improve docs and validations #8

merged 9 commits into from
Dec 23, 2024

Conversation

wvanheerde
Copy link
Collaborator

@wvanheerde wvanheerde commented Dec 22, 2024 •
edited
Loading

This PR:

  • Updates the docs to include some instructions on setting up the module.
  • Improves TF validations on composition, giving earlier feedback on a misconfigured composition.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output 

Success! The configuration is valid.

@wvanheerde wvanheerde changed the title Improve docs and validations feat: Improve docs and validations Dec 22, 2024
@wvanheerde wvanheerde changed the title feat: Improve docs and validations enhancement: Improve docs and validations Dec 22, 2024
@wvanheerde wvanheerde marked this pull request as ready for review December 22, 2024 10:47
@wvanheerde wvanheerde added the enhancement New feature or request label Dec 22, 2024
@wvanheerde
docs: add development instructions
1faccca
@wvanheerde
Merge branch 'improve-docs-and-validations' of github.com:schubergphi…
d0ee54b 
…lis/terraform-aws-mcaf-resource-scheduler into improve-docs-and-validations
@github-actions github-actions bot added the feature New feature or request label Dec 22, 2024
@wvanheerde wvanheerde removed the feature New feature or request label Dec 22, 2024
marwinbaumannsbp
marwinbaumannsbp reviewed Dec 23, 2024
View reviewed changes
README.md Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@github-actions github-actions bot added the feature New feature or request label Dec 23, 2024
@wvanheerde wvanheerde merged commit 1e619a9 into main Dec 23, 2024
7 checks passed
@wvanheerde wvanheerde deleted the improve-docs-and-validations branch December 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwinbaumannsbp marwinbaumannsbp marwinbaumannsbp approved these changes

@dschrander dschrander dschrander approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wvanheerde @dschrander @marwinbaumannsbp