Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add initial core implementation #1

Merged
merged 9 commits into from
Nov 4, 2024
Merged

feature: add initial core implementation #1

merged 9 commits into from
Nov 4, 2024

Conversation

Dennisvandermeulen
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖failure

Terraform Validation 🤖skipped

Validation Output

@Dennisvandermeulen Dennisvandermeulen changed the title misc: add initial core implementation feature: add initial core implementation Nov 1, 2024
@github-actions github-actions bot added the feature New feature or request label Nov 4, 2024
Blankf
Blankf approved these changes Nov 4, 2024
View reviewed changes
Copy link

@Blankf Blankf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as initial looks ok, overlaps a lot with keyvault but has future purpose to expand this module

@Dennisvandermeulen Dennisvandermeulen merged commit a1a7bce into main Nov 4, 2024
@Dennisvandermeulen Dennisvandermeulen deleted the initial-core branch November 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blankf Blankf Blankf approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dennisvandermeulen @Blankf