-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TOML lists in cmake.define #921
Conversation
Can you add some docs on the change, particularly regarding the nested list syntax? scikit-build-core/docs/configuration.md Line 408 in 7636e7b
Maybe as a scikit-build-core/docs/configuration.md Lines 418 to 425 in 7636e7b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A mention in the docs, and one unit test would be nice, but not required. Thanks! Not sure I would have come up with this solution.
@henryiii - I added a unit test to |
I've adjusted the docs style to match the existing style a bit better, otherwise looks fantastic. |
Thanks! Happy to contribute 🙂 |
@henryiii -- not sure why one of the CI bots failed. Hoping it's just an intermittent failure. Merged in main to re-run. |
Yes, it is. Even with a rebuild PyPy is flaky in pretty much every repo. |
Adds support for specifying CMake lists in
cmake.define
using TOML lists:Escapes semicolons in list items so as to allow nested lists.
Fixes #874