-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The latest/
directory in git repository
#170
Conversation
Preparing this PR eats some energy, so if we agree that something like this is worth it (and there's some reviewer and committer), I'll rebase and re-propose. |
As stated in sclorg/container-common-scripts#4 this gets a +1 from me. |
The question is whether it is correct to reference file in "9.5" directory.. something like this was also mentioned in 0860eb4 Having "single source of truth" could resolve this once and forever.. |
+1 from me too. One question, where to write "rule" like this? (other sclorg/ images should follow this PR and have |
I agree with the question but from the comment on the commit you linked it seems some people actually link to the repository this way. |
Btw., if (at the time of branching) we moved 9.5 to 9.6, and created the new 9.5 directory (what @torsava proposed I believe) we would loose the history because git thinks that 9.5 stayed "unchanged" and 9.6 is new. So we would have to have two commits for each "branching" time ... (1. commit does the movement, and the 2. commit C&P). So in the end, the "latest" + symlink alternative sounds like we can more easily "enforce" such guideline. |
I neither feel we are blocked here, and waiting is IMO not that important (if there were such links to 9.5, those would be soon fixed once we move |
Indeed you would need 2 commits. I like the moving alternative because I feel it makes the repo cleaner, but I agree it would be impossible to enforce and thus using the latest approach will likely be more sustainable. |
I like this approach as well (sorry for delay). |
fd9b7ed
to
4141a9b
Compare
I rebased the PR; the first commit is prerequisite from PR #180. |
|
4141a9b
to
2384f66
Compare
Good catch, thanks! Should be fixed. |
2384f66
to
ef7b3e6
Compare
Move '9.2' into 'latest' to keep the whole commit history.
Copy 'latest' into '9.2'. We sacrifice git history of 9.2 to have better history in latest.
Copy related changes from 9.5 into latest, and replace the whole 9.5 with symlink to latest.
ef7b3e6
to
15dc0ca
Compare
lgtm. Lets merge and try out this approach. |
Comply with sclorg/container-common-scripts#4