Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a go vet for consistency #191

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

@7h3-3mp7y-m4n 7h3-3mp7y-m4n commented Oct 17, 2024

Added a go vet ./.. for reporting suspicious constructs that might indicate errors ... like we have now in score-k8s: https://github.com/score-spec/score-k8s/blob/main/.github/workflows/ci.yaml#L20-L21.

Description

What does this PR do?

it updates the ci.yml and adds a new test called Run Go Vet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mathieu-benoit mathieu-benoit merged commit d6e498c into score-spec:main Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants