Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .gitignore to downloads folder #858

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

IMACULGY
Copy link

Description

All files in the downloads folder are ignored when pushing to remote branch. This prevents user-downloaded files from showing up in future PRs.

Related Issue

#857

Motivation and Context

GCI 2019 task.

How Has This Been Tested?

Tested by creating files with multiple different extensions in the downloads folder, and then trying to push them.

Screenshots (In case of UI changes):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmehant kmehant requested a review from JaDogg January 16, 2020 05:57
@@ -88,7 +88,7 @@ __pycache__/
build/
develop-eggs/
dist/
downloads/
#downloads/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't comment remove this line 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants