Added test coverage and renamed existing test files to allow coverage to work #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaDogg
reviewed
Mar 10, 2020
| @@ -0,0 +1,46 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
What does this file do? is it a script?
There was a problem hiding this comment.
this file adds a command for running the tests without the coverage and with the coverge the respective commands being python TestCommands.py test and python TestCommands.py cov
|
@JaDogg For running the tests the command is |
| from UserManager import * | ||
| import unittest | ||
|
|
||
|
|
There was a problem hiding this comment.
Is there a reason why there are two blank lines between code blocks instead of one?
There was a problem hiding this comment.
No these are left because of keeping the code easy to read but if you think i will remove the extra line.
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| manager.run() |
There was a problem hiding this comment.
Add new line at the end of the file.
… the tests at once and renamed the existing test files for coverage to work
carpecodeum
force-pushed
the
added_test_coverage
branch
from
70f6e2f to
1aa7b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added test coverage to existing tests and displayed them in an orderly fashion. Added extra commands to run all the tests at once. Also, edited the names of the existing tests files to allow the test coverage to work.
Related Issue #851
Motivation and Context
The project was lacking the magnitude and the reach of the impact of the existing tests have on the whole flask backend this can help ensure maximum efficiency of the reach of the test cases present.
How Has This Been Tested?
Types of changes
Checklist: