Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weapon light followup #6484

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Weapon light followup #6484

merged 1 commit into from
Dec 25, 2024
+46 −28

Conversation

Kestrellius
Copy link
Contributor

Followup to #6474. Cleans up the logic flow some.

@wookieejedi wookieejedi added cleanup A modification or rewrite of code to make it more understandable or easier to maintain. graphics A feature or issue related to graphics (2d and 3d) labels Dec 22, 2024
@wookieejedi wookieejedi added this to the Release 25.0 milestone Dec 22, 2024
Goober5000
Goober5000 requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@Goober5000 Goober5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kestrellius and I were discussing what changes might be needed here, so hold off on merging until I can review this.

Goober5000
Goober5000 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@Goober5000 Goober5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. 👍 It's clear and well-organized.

@Goober5000 Goober5000 merged commit 7c82072 into scp-fs2open:master Dec 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BMagnu BMagnu BMagnu approved these changes

@Goober5000 Goober5000 Goober5000 approved these changes

Assignees
No one assigned
Labels
cleanup A modification or rewrite of code to make it more understandable or easier to maintain. graphics A feature or issue related to graphics (2d and 3d)
Projects
None yet
Milestone
Release 25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Kestrellius @Goober5000 @BMagnu @wookieejedi