adjust-audio-volume adjustments #6488
Open
+38
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make some modifications to the adjust-audio-volume infrastructure: 1. Add an `aav_volume` array for ease of access to all three volume variables. Refactor `snd_adjust_audio_volume()` to use this array to avoid duplicating code. 2. Move `update_looping_sound_volumes()` to be handled in parallel with `audiostream_set_volume_all()`, and for the same reason: avoid setting the sound volume for every looping sound on every frame if the volume has not changed. 3. If the volume is to be adjusted immediately, apply the relevant changes without waiting for `snd_do_frame()` to be called on the next frame. Resolves scp-fs2open#6291. 4. Fix some edge cases in `adjust_volume_on_frame()`.
Goober5000
added
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some modifications to the adjust-audio-volume infrastructure:
aav_volumearray for ease of access to all three volume variables. Refactorsnd_adjust_audio_volume()to use this array to avoid duplicating code.update_looping_sound_volumes()to be handled in parallel withaudiostream_set_volume_all(), and for the same reason: avoid setting the sound volume for every looping sound on every frame if the volume has not changed.snd_do_frame()to be called on the next frame. Resolves FR: Make mission volume levels at mission start smarter #6291.adjust_volume_on_frame().