This repository has been archived by the owner on Nov 27, 2019. It is now read-only.
Stop paging listings after page 99 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a page size of 100, the API won't return results for page 100, page 99 is the last valid one. Known issue: http://developer.zoopla.com/forum/read/162309
|
This arose because Zoopla were giving out seemingly bad results. For a particular postcode search, the first page of results had only 99 entries, instead of 100. Subsequent pages had the correct number of entries, but this meant that the number found was one lower than the expected result count. Once the code reached page 100, it errored. Really, this shouldn't happen unless you're doing a big search (the example in the Zoopla forum was searching for properties in London). |
| @@ -92,6 +95,11 @@ def finished(): | |||
| L.debug("Stop paging, yielded={}, result_count={}".format( | |||
| num_yielded, result_count)) | |||
| return True | |||
| elif args['page_number'] == 100: | |||
There was a problem hiding this comment.
This should be >= 100 if for example someone picks a specific page number > 100 rather than simply incrementing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a page size of 100, the API won't return results for page
100, page 99 is the last valid one.
Known issue: http://developer.zoopla.com/forum/read/162309