Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use feature based caches and update metrics #123

Merged
merged 19 commits into from
Nov 2, 2024

Conversation

wagpa
Copy link
Contributor

@wagpa wagpa commented Oct 20, 2024

Changes

  • replace closure-type metrics capture with custom macro #[metrics(...)]
  • add additional metrics
  • fixate cache structure to two cache levels (local and remote)
  • add additional docker image for Redis cache

Breaking Changes

  • move Redis remote cache behind build feature
  • disable Redis remote cache by default (affects default image)

To continue using Xenos with Redis as remote cache, the Redis docker image has to be used. These changes were made to (1) improve the readability of the code (in respect to the metrics) and (2) to ensure that future caches do not conflict with their dependencies or bloat up the binary.

@wagpa wagpa requested a review from scrayos October 21, 2024 08:51
Copy link
Member

@scrayos scrayos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've reviewed everything and looks nice! We can look into the github workflow changes together.

.github/workflows/docker-redis.yml Outdated Show resolved Hide resolved
Dockerfile.redis Outdated Show resolved Hide resolved
@scrayos scrayos merged commit 24b2a71 into main Nov 2, 2024
2 checks passed
@scrayos scrayos deleted the dev/static-build-and-metrics branch November 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace complex caching structure with typed two level cache Use custom macro for metrics
2 participants