Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Server permissions #28

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

Nyrok
Copy link
Member

@Nyrok Nyrok commented Aug 25, 2024

Hello SculkMP team, I started the implementation of Server permissions and I wonder some things:

  • What is the mainline for this feature, do you want to have differences from CloudburstMC ?
  • At what stage do you want it to load ?
  • Will Server class manage DefaultPermissions or the PermissionsManager would do it ?
  • The ops.txt file will still be a file as of Cloudburst, or do you imagine something else ?
    Thank you for answering.

@Nyrok Nyrok added Priority: Medium Medium-priority issues of moderate importance. Status: Incomplete Issues missing necessary information. Category: API Issues and discussions related to the software's API. labels Aug 25, 2024
@Nyrok Nyrok requested a review from JblusItsMe August 25, 2024 13:28
@JblusItsMe
Copy link
Member

Hello nyrok, sorry to wait for the answer to you questions.

The permission manager file, is a nothing more basic file, is should be possible create permissions, from a grant or not (for example if have wish that there are already all permissions of staff by default).

Ideally, it should be loaded before loading the commands in the Server file. Afterwards we can check when loading the commands if the permissions exists.

Ideally, the DefaultPermissions file would be managed by PermissionManager with an init for exemple, to load all commands with the server file or as you like on the function name.

The file ops.txt will add by default to the person the DefaultPermissionNames.GROUP_OPERATOR

If you have any other questions, please do not hesitate, we will be happy to answer them @Nyrok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Issues and discussions related to the software's API. Priority: Medium Medium-priority issues of moderate importance. Status: Incomplete Issues missing necessary information.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants