Add PlayerJoinEvent and broadcast join messages #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzaleeX
added
Priority: Low
Introduced the PlayerJoinEvent class to handle player join events and broadcast customizable join messages. Updated the SpawnResponsePacketHandler to trigger and call the event while broadcasting the localized join message. Added a new localization key for the join message in the LanguageKeys class and language resource file.
Updated the player join message placeholders in `fr_FR.ini` and `en_GB.ini` to use consistent formatting with parameterized placeholders like `{%0}`. This ensures proper rendering of dynamic player names across different languages.
Adjusted join message logic to handle empty custom messages and default to translated messages if necessary. Removed unnecessary spaces in language files for consistency and to align with formatting standards.
Moved player join logic from SpawnResponsePacketHandler to Player class, encapsulating it in the new `doFirstSpawn` method. Ensured `PlayerJoinEvent` uses `@NonNull` annotations for better null safety. This improves code maintainability and separation of concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced the PlayerJoinEvent class to handle player join events and broadcast customizable join messages. Updated the SpawnResponsePacketHandler to trigger and call the event while broadcasting the localized join message. Added a new localization key for the join message in the LanguageKeys class and language resource file.