Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARM AInvs for det_ext changes #844

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

corlewis
Copy link
Member

Following on from #824, this PR copies the AInvs update across to ARM for the changes to det_ext and the scheduler state.

@corlewis corlewis requested review from Xaphiosis and lsf37 December 19, 2024 04:17
@corlewis corlewis self-assigned this Dec 19, 2024
@corlewis
Copy link
Member Author

Ignore the first commit for reviewing purposes, it contains the limited changes that could be copied directly across from AArch64 AInvs.

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Always nice to see more lines removed than added.

Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is this incremental work, since it's ARM only?

@corlewis
Copy link
Member Author

Looks good. Is this incremental work, since it's ARM only?

Yes, very incremental, there's still a fair bit more to do before the det_ext_state branch can be merged into master but there's other work that depends on this so I wanted it reviewed early.

@corlewis corlewis force-pushed the get_ext_state_arm_ainvs branch from 918da15 to f428ccf Compare December 19, 2024 23:25
@corlewis corlewis merged commit ae7b48b into seL4:det_ext_state Dec 19, 2024
10 of 14 checks passed
@corlewis corlewis deleted the get_ext_state_arm_ainvs branch December 19, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants