-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move template to external file #8
base: master
Are you sure you want to change the base?
Conversation
I also thought about externalizing the template but as far as I know this is a problem when minimizing / uglifying the code as the tools don't recognize the template and therefore do not include it. Or am I missing something? One solution would be to include two versions, one with inline-template and one without. But then there has to be made a choice which version should be referenced as the main version in bower.json. |
For one project I created a script doing this automatically ( https://gist.github.com/sebastianha/613e37aedfd99a1e9fa2 ) and I hooked it into pre-commit of git. This could be a solution but then the bower.json decision is still open. |
As far as I know minification is ok if you use html2js like the angular-ui
|
Thanks for the hint to html2js, this seems to be exactly what I was looking for! I will take a look at it. |
Also allows you to use jade which I personally prefer :-)
|
Yeah - The minification is more a function of grunt/gulp compiling process. I'd also say the same argument goes for abstracting the CSS you're including for the size attribute. Would be better for handle that thru the CSS not the JS |
Yeah I agree that making the large etc attr is bad but prob another issue
|
Moved template to an external file to separate HTML from the JS
e.g. I don't have the Glythicon installed so I need to use my own template
Used the Bootstrap UI folder naming convention.