Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_unique_points_mask more efficient #813

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

uri-granta
Copy link
Collaborator

Related issue(s)/PRs: #781

Summary

Make get_unique_points_mask run in parallel. Since this approach detects connected graph components, it can trip up on examples like [1,2,3,4] with tolerance 1, which should return two points not one, even though all the points are connected. However, we can fix this using what will almost certainly be a small number of iterations.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

Copy link
Collaborator

@khurram-ghani khurram-ghani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Glad we could come up with a nice parallel algorithm :-)

@uri-granta uri-granta merged commit 5528236 into develop Jan 24, 2024
12 checks passed
@uri-granta uri-granta deleted the uri/parallelise_get_unique_points_mask branch January 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants