-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DeepEnsemble with float32 #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a step in the right direction :)
left some comments - this checks if all runs, which is necessary, but certain parts of the pipeline might nevertheless cast back and forth which we don't test here - I'm not sure whats the best way to do that, just saying this is not sufficient - we'll probably need to test each individual component, or perhaps each individual object should have a dtype property which could facilitate that...
cannot recall now, but do we have dtype checks in unit tests of the DE model - e.g. checking prediction, sample methods, and trajectory sampler?
By patching tf.cast I've verified that there are no unexpected casts happening in the test. The only casts are in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the diff became a bit mangled, but I think its good now
FYI you can add ?w=1 to the diff url to get it to ignore whitespace, which makes it much more readable! |
Related issue(s)/PRs:
Summary
...
Fully backwards compatible: yes / no
PR checklist