Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Add a README #26

Merged
merged 26 commits into from
Mar 28, 2019
Merged

Add a README #26

merged 26 commits into from
Mar 28, 2019

Conversation

SimonBarendse
Copy link
Member

No description provided.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start on the README! Feels a bit incomplete, feels like we can improve the developer experience a bit. Check out my comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting better and better! I have a few additions and tweaks to further improve the developer experience.

I think this README.md can be one of our most important READMEs of all, as it is the starting point for getting started with SecretHub. Therefore we should treat it as a real landing page and give it all the goodies it deserves.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few minor comments, feel free to merge when satisfied.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SimonBarendse SimonBarendse merged commit 3426c8e into develop Mar 28, 2019
@SimonBarendse SimonBarendse deleted the feature/readme branch March 28, 2019 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants