-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pre-commit #215
base: master
Are you sure you want to change the base?
Document pre-commit #215
Conversation
Thanks for linking. I've made a separate PR to close the first issue and updated the docs message slightly. Should be good to go, but feel free to edit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I'd like to have this better documented in Import Linter, but to be honest I'm not completely clear on how precommit works and I'm not able to get this working myself in this way (problems with Python path, possibly the same as #214).
I'm a bit reluctant to merge without understanding better what's going on - if I can't support it for myself, how can I for others? Probably the best way to do that would be to have a brief pairing session to get these docs into shape, is that something you might have time for? If so feel free to reach out via email and we can find a time.
|
||
repos: | ||
- repo: https://github.com/seddonym/import-linter | ||
rev: v2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in thinking this should be the latest version of Import Linter?
It would be good if this could be pulled in dynamically somehow from the release
variable defined in docs/conf.py
. I tried to figure out how to do this for about ten minutes, not sure how easy this would be. How's your Sphinx?
Closes #213